Skip to content

[ENH] Build chroma-load-start binary and add it to chroma-load container #4370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

jasonvigil
Copy link
Contributor

@jasonvigil jasonvigil commented Apr 24, 2025

Description of changes

This will be used to initialize new runs of the verification service, by executing the binary in the image.

Test plan

Verify the built image contains the expected binary:

docker buildx build -f ./rust/load/Dockerfile --build-arg RELEASE_MODE=1 --target load_service -t load-service:local .

docker run --rm --entrypoint ./chroma-load-start load-service:local

This will be used to initialize new runs of the verification service, by
executing the binary in the image.
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor

@eculver eculver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5/5 ⭐s

@jasonvigil jasonvigil merged commit c45d24f into main Apr 24, 2025
69 checks passed
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 24, 2025
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 24, 2025
@jasonvigil jasonvigil deleted the jason/add-chroma-load-start-binary branch April 24, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants