Skip to content

[CHORE] remove hnsw-lib from core dependencies #4385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

jairad26
Copy link
Contributor

@jairad26 jairad26 commented Apr 25, 2025

Description of changes

#4382 (comment)

this PR removes hnsw-lib from core dependencies, removes it from the dockerfile, and moves it to dev dependencies in pyproject

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@jairad26 jairad26 force-pushed the jai/remove-hnsw-lib-dep branch from 7e6a3e5 to 2af267d Compare April 28, 2025 16:24
@jairad26 jairad26 changed the title [CHORE] remove hnsw-lib from dependencies [CHORE] remove hnsw-lib from core dependencies Apr 28, 2025
@jairad26 jairad26 force-pushed the jai/remove-hnsw-lib-dep branch 2 times, most recently from bf57c5e to 31c9a88 Compare April 28, 2025 16:47
@jairad26 jairad26 marked this pull request as ready for review April 28, 2025 17:12
Copy link
Collaborator

@HammadB HammadB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm Df works before merging

Copy link
Collaborator

@HammadB HammadB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually should we just delete this DF entirely? It is legacy python specific

@jairad26 jairad26 force-pushed the jai/remove-hnsw-lib-dep branch 6 times, most recently from b903efe to ac6474f Compare April 28, 2025 21:06
@jairad26 jairad26 force-pushed the jai/remove-hnsw-lib-dep branch from ac6474f to 2823b7c Compare April 28, 2025 21:36
@jairad26 jairad26 merged commit 21ab6b8 into main Apr 29, 2025
70 checks passed
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants