[ENH] Add load service to local dev tiltfile #4397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
jasonvigil
commented
Apr 29, 2025
| config.yaml: | | ||
| load_service: | ||
| service_name: "chroma-load" | ||
| otel_endpoint: "http://otel-collector.chroma:4317" |
There was a problem hiding this comment.
.chroma... It's always DNS 🙃
eculver
reviewed
Apr 29, 2025
| .with_http() | ||
| .with_http_client(client) | ||
| let tracing_span_exporter = opentelemetry_otlp::SpanExporter::builder() | ||
| .with_tonic() |
There was a problem hiding this comment.
so this was mis-configured to use HTTP instead of gRPC too? Is that what the with_tonic() also changes?
aside: I wish that this was somehow made our "default" Chroma setup so that it's consistent for all our rust code.
There was a problem hiding this comment.
Only chroma-load is not using our default otel setup. See tracing crate.
There was a problem hiding this comment.
This is because chroma-load was exporting to honeycomb directly. I'd love to see it unified.
eculver
approved these changes
Apr 29, 2025
jasonvigil
force-pushed
the
jason/add-load-service-to-tiltfile
branch
from
abe253e to
978c418
Compare
Make the trace exporter to export all INFO and above traces (not just ERROR).
jasonvigil
force-pushed
the
jason/add-load-service-to-tiltfile
branch
from
978c418 to
339db10
Compare
rescrv
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Make the trace exporter to export all INFO and above traces (not just ERROR).
Also, update load service tracing to use GRPC (to match our other services).
Test plan
Ran locally via
tilt up. Verified traces appear underchroma-loadservice in jaeger.Documentation Changes
n/a