Skip to content

[ENH]: better errors in ComputeUnusedFilesOperator #4400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented Apr 29, 2025

Description of changes

This operator was previously swallowing error details.

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@codetheweb codetheweb force-pushed the feat-better-errors-in-compute-unused-files-operator branch from a2f51f7 to b6a6239 Compare April 29, 2025 19:12
@codetheweb codetheweb marked this pull request as ready for review April 29, 2025 19:13
@codetheweb codetheweb requested a review from Sicheng-Pan April 29, 2025 19:13
@codetheweb codetheweb enabled auto-merge (squash) April 29, 2025 19:14
@codetheweb codetheweb merged commit 4531531 into main Apr 29, 2025
69 checks passed
warpbuild-benchmark-bot bot added a commit to WarpBuilds/chroma that referenced this pull request Apr 29, 2025
@codetheweb codetheweb deleted the feat-better-errors-in-compute-unused-files-operator branch April 29, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants