[ENH] Fork the wal3 log. #4416
Merged
[ENH] Fork the wal3 log. #4416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This commit adds parity for copying the wal3 log. This supports forking.
rescrv
force-pushed
the
rescrv/fork-the-log
branch
from
e619331 to
2479280
Compare
Sicheng-Pan
reviewed
May 1, 2025
rust/log-service/src/lib.rs
Outdated
Comment on lines
800
to
806
| let cursor_name = &COMPACTION; | ||
| let witness = cursors.load(cursor_name).await.map_err(|err| { | ||
| Status::new(err.code().into(), format!("Failed to load cursor: {}", err)) | ||
| })?; | ||
| let offset = witness | ||
| .map(|x| x.1.position) | ||
| .unwrap_or(LogPosition::from_offset(1)); |
There was a problem hiding this comment.
Is this the compaction offset? If so does it represent the last offset has been compacted or the next offset to compact?
Sicheng-Pan
reviewed
May 1, 2025
Comment on lines
+823
to
+825
| let max_offset = log_reader.maximum_log_position().await.map_err(|err| { | ||
| Status::new(err.code().into(), format!("Failed to copy log: {}", err)) | ||
| })?; |
There was a problem hiding this comment.
Similar question: Is this the offset of the next log to be written on the log or the last log written
Sicheng-Pan
reviewed
May 1, 2025
| }; | ||
|
|
||
| #[tokio::test] | ||
| async fn test_k8s_integration_80_copy() { |
There was a problem hiding this comment.
nit: can you extend this test to check: if new data is written to the original log, the copied log does not change, and vice versa
Sicheng-Pan
approved these changes
May 1, 2025
warpbuild-benchmark-bot bot
added a commit
to WarpBuilds/chroma
that referenced
this pull request
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This commit adds parity for copying the wal3 log. This supports
forking.
Test plan
Get test_fork to pass with this with wal3 enabled.
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
None for chroma. wal3 interface not public.