Skip to content

[BUG] Handle duplicates in chroma-load. #4423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025
Merged

[BUG] Handle duplicates in chroma-load. #4423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions rust/load/src/data_sets.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,7 +760,10 @@ impl DataSet for ReferencingDataSet {
let mut keys = vec![];
let num_keys = gq.limit.sample(guac);
for _ in 0..num_keys {
keys.push(KeySelector::Random(gq.skew).select(guac, self));
let key = KeySelector::Random(gq.skew).select(guac, self);
if !keys.contains(&key) {
keys.push(key);
}
}
let collection = client.get_collection(&self.operates_on).await?;
// TODO(rescrv): from the reference collection, pull the documents and embeddings and
Expand All @@ -787,7 +790,10 @@ impl DataSet for ReferencingDataSet {
let mut keys = vec![];
let num_keys = qq.limit.sample(guac);
for _ in 0..num_keys {
keys.push(KeySelector::Random(qq.skew).select(guac, self));
let key = KeySelector::Random(qq.skew).select(guac, self);
if !keys.contains(&key) {
keys.push(key);
}
}
let keys = keys.iter().map(|k| k.as_str()).collect::<Vec<_>>();
if let Some(res) = self.references.get_by_key(client, &keys).await? {
Expand Down Expand Up @@ -835,7 +841,10 @@ impl DataSet for ReferencingDataSet {
let collection = client.get_collection(&self.operates_on).await?;
let mut keys = vec![];
for offset in 0..uq.batch_size {
keys.push(uq.key.select_from_reference(self, offset));
let key = uq.key.select_from_reference(self, offset);
if !keys.contains(&key) {
keys.push(key);
}
}
let keys = keys.iter().map(|k| k.as_str()).collect::<Vec<_>>();
if let Some(res) = self.references.get_by_key(client, &keys).await? {
Expand Down Expand Up @@ -1019,7 +1028,10 @@ impl DataSet for VerifyingDataSet {
}

for _ in 0..num_keys {
keys.push(KeySelector::Random(gq.skew).select(guac, self));
let key = KeySelector::Random(gq.skew).select(guac, self);
if !keys.contains(&key) {
keys.push(key);
}
}

let reference_collection = client
Expand Down Expand Up @@ -1208,7 +1220,10 @@ impl DataSet for VerifyingDataSet {
);

for offset in 0..uq.batch_size {
keys.push(uq.key.select_from_reference(self, offset));
let key = uq.key.select_from_reference(self, offset);
if !keys.contains(&key) {
keys.push(key)
}
}
let keys = keys.iter().map(|k| k.as_str()).collect::<Vec<_>>();
if let Some(res) = self.reference_data_set.get_by_key(client, &keys).await? {
Expand Down
Loading