[CLN] Use GRPC for chroma-load OTEL #4427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, remove sampling. Will leverage refinery for this instead.
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
rescrv
requested changes
May 2, 2025
| .with_config(trace_config) | ||
| .build(); | ||
| let tracer = tracer_provider.tracer(service_name.clone()); | ||
| // TODO(MrCroxx): Should we the tracer provider as global? | ||
| // global::set_tracer_provider(tracer_provider); | ||
|
|
||
| // Prepare meter. |
There was a problem hiding this comment.
Refinery doesn't support metrics and Honeycomb doesn't support tonic. This was setup the way it is to get metrics into honeycomb. Metrics, not traces.
There was a problem hiding this comment.
We can use otel-collector as the same endpoint for both metrics and traces. This simplifies our config and setup complexity (from chroma service standpoint, at least)
rescrv
approved these changes
May 2, 2025
warpbuild-benchmark-bot bot
added a commit
to WarpBuilds/chroma
that referenced
this pull request
May 2, 2025
tjkrusinskichroma
pushed a commit
that referenced
this pull request
May 3, 2025
## Description of changes Remove sampling. Will leverage refinery for this instead. ## Test plan These changes are untested. However, it is now using (mostly) the same setup code as the other chroma services (which are working). So, we can test in staging after this is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Remove sampling. Will leverage refinery for this instead.
Test plan
These changes are untested. However, it is now using (mostly) the same setup code as the other chroma services (which are working). So, we can test in staging after this is merged.