Skip to content

[CLN] Warn on log pull failure instead of error #4435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions rust/worker/src/execution/orchestration/compact.rs
Original file line number Diff line number Diff line change
Expand Up @@ -794,10 +794,14 @@ impl Handler<TaskResult<FetchLogOutput, FetchLogError>> for CompactOrchestrator
tracing::info!("Pulled Logs Up To Offset: {:?}", self.pulled_log_offset);
}
None => {
tracing::warn!("No logs were pulled from the log service, this can happen when the log compaction offset is behing the sysdb.");
// TODO(hammadb): We can repair the log service's understanding of the offset here, as this only happens
// when the log service is not up to date on the latest compacted offset, which leads it to schedule an already
// compacted collection.
self.terminate_with_result(
Err(CompactionError::InvariantViolation(
"Logs should be present for compaction",
)),
Ok(CompactionResponse {
collection_id: self.collection_id,
}),
ctx,
)
.await;
Expand Down
Loading