[ENH]: Add retry for add, update and upsert #4457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
HammadB
reviewed
May 6, 2025
HammadB
approved these changes
May 6, 2025
sanketkedia
changed the title
chroma-droid
pushed a commit
that referenced
this pull request
May 6, 2025
## Description of changes _Summarize the changes made by this PR._ - Improvements & Bug fixes - Adds exponential retry to coll.add(), coll.update() and coll.upsert() for duplicate key errors returned by postgres - New functionality - ... ## Test plan _How are these changes tested?_ - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes None
chroma-droid
pushed a commit
that referenced
this pull request
May 6, 2025
## Description of changes _Summarize the changes made by this PR._ - Improvements & Bug fixes - Adds exponential retry to coll.add(), coll.update() and coll.upsert() for duplicate key errors returned by postgres - New functionality - ... ## Test plan _How are these changes tested?_ - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes None
sanketkedia
added a commit
that referenced
this pull request
May 6, 2025
This PR cherry-picks the commit 048583d onto rc/2025-05-02. If there are unresolved conflicts, please resolve them manually. Co-authored-by: Sanket Kedia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
None