Skip to content

[CLN] Pass Chroma API key via env var for chroma-load-start #4469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

jasonvigil
Copy link
Contributor

Description of changes

This change updates chroma-load-start to read the APi key from the environment. It is a bit more secure than passing the API key via the process arguments, which is potentially readable by other processes on the system.

Test plan

Tested locally via tilt.

@jasonvigil jasonvigil requested a review from rescrv May 7, 2025 00:09
Copy link

github-actions bot commented May 7, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

This is a bit more secure than passing the API key via the process arguments,
which is potentially readable by other processes on the system.
@jasonvigil jasonvigil force-pushed the jason/read-chroma-api-key-from-env branch from 60af844 to 53b687b Compare May 7, 2025 00:29
@jasonvigil jasonvigil enabled auto-merge (squash) May 7, 2025 00:29
@jasonvigil jasonvigil merged commit 7e50089 into main May 7, 2025
70 checks passed
@jasonvigil jasonvigil deleted the jason/read-chroma-api-key-from-env branch May 7, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants