Skip to content

[ENH]: Add quota on regex pattern length #4503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

[ENH]: Add quota on regex pattern length #4503

merged 1 commit into from
May 8, 2025

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented May 8, 2025 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Removed the num regex predicates
    • Added the regex pattern length with a default of 0
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@sanketkedia Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sanketkedia sanketkedia requested review from HammadB and Sicheng-Pan May 8, 2025 20:19
@sanketkedia sanketkedia marked this pull request as ready for review May 8, 2025 20:19
@propel-code-bot propel-code-bot
Copy link
Contributor

propel-code-bot bot commented May 8, 2025 •
edited
Loading

This PR replaces the NumRegexPredicates quota type with RegexPatternLength to control the length of regex patterns in filters rather than the number of predicates.

This summary was automatically generated by @propel-code-bot

HammadB
HammadB reviewed May 8, 2025
View reviewed changes
Copy link
Collaborator

@HammadB HammadB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a test that this gets enforced correctly given a Where?

@sanketkedia sanketkedia force-pushed the 05-08-_enh_add_quota_on_regex_pattern_length branch from b760686 to 2b09de3 Compare May 8, 2025 21:11
@sanketkedia
Copy link
Contributor Author

Test added in https://github.com/chroma-core/hosted-chroma/pull/2625

@sanketkedia sanketkedia merged commit ac331a6 into main May 8, 2025
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB approved these changes

@Sicheng-Pan Sicheng-Pan Awaiting requested review from Sicheng-Pan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanketkedia @HammadB