-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ENH]: ListCollectionsToGc
returns lineage file path, group by fork tree, accept optional tenant for filtering
#4529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH]: ListCollectionsToGc
returns lineage file path, group by fork tree, accept optional tenant for filtering
#4529
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
0b0d572
to
2570a94
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
f6cc527
to
82416a2
Compare
ListCollectionsToGc
should return lineage file path, group by fork treeListCollectionsToGc
returns lineage file path, group by fork tree, accept optional tenant for filtering
Enhanced ListCollectionsToGc for Fork Tree Management This PR enhances the Key Changes: Affected Areas: This summary was automatically generated by @propel-code-bot |
82416a2
to
9e05d4e
Compare
d493aff
to
8e91522
Compare
8e91522
to
dc6a82f
Compare
… tree, accept optional tenant for filtering (#4529) ## Description of changes Includes several updates to the `ListCollectionsToGc` gRPC method: - returns the lineage file path, if present - only returns the root collection for fork trees - accepts an optional tenant parameter for test isolation. Because `ListCollectionsToGc` now returns collections that are part of fork trees, I also updated GC to skip collections with a populated `lineage_file_path` (i.e. the root collection in a fork tree). ## Test plan _How are these changes tested?_ Added tests covering the fork tree grouping and GC behavior on forked collections. ## Documentation Changes _Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs section](https://github.com/chroma-core/chroma/tree/main/docs/docs.trychroma.com)?_ n/a
Description of changes
Includes several updates to the
ListCollectionsToGc
gRPC method:Because
ListCollectionsToGc
now returns collections that are part of fork trees, I also updated GC to skip collections with a populatedlineage_file_path
(i.e. the root collection in a fork tree).Test plan
How are these changes tested?
Added tests covering the fork tree grouping and GC behavior on forked collections.
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?
n/a