-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ENH]: add readiness probe for garbage collector #4662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
✅ The Helm chart's version was changed. Your changes to the chart will be published upon merge to |
Add Readiness Probe to Garbage Collector Service This PR introduces a readiness probe to the garbage collector component in the Chroma distributed system, enabling Kubernetes to verify when the garbage collector service is ready to accept traffic. The implementation involves adding a minimal gRPC health service and configuring the Helm and k8s manifests accordingly, with corresponding updates to Rust, proto, and configuration code. Key Changes: Affected Areas: This summary was automatically generated by @propel-code-bot |
d7aba55
to
9e68ab9
Compare
9e68ab9
to
d71fd60
Compare
d71fd60
to
18e5536
Compare
@@ -47,6 +47,7 @@ pub use tenant::*; | |||
pub use types::*; | |||
pub use where_parsing::*; | |||
|
|||
#[allow(clippy::all)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is needed to ignore a new warning in the prost-genenerated code--happens because we have a service with no methods and prost generates slightly unidiomatic code
Description of changes
Adds a readiness probe for GC.
Test plan
How are these changes tested?
Verified that the service was marked ready using kubectl.
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?
n/a