-
Notifications
You must be signed in to change notification settings - Fork 10
Clean-up/Refactoring of old code #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Piskun <[email protected]>
Signed-off-by: Alexander Piskun <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
==========================================
+ Coverage 99.81% 99.84% +0.02%
==========================================
Files 36 36
Lines 3330 3277 -53
==========================================
- Hits 3324 3272 -52
+ Misses 6 5 -1
|
Signed-off-by: Alexander Piskun <[email protected]>
Signed-off-by: Alexander Piskun <[email protected]>
Signed-off-by: Alexander Piskun <[email protected]>
Signed-off-by: Alexander Piskun <[email protected]>
Signed-off-by: Alexander Piskun <[email protected]>
…rs" in httpx.event_hooks Signed-off-by: Alexander Piskun <[email protected]>
Signed-off-by: Alexander Piskun <[email protected]>
Signed-off-by: Alexander Piskun <[email protected]>
Signed-off-by: Alexander Piskun <[email protected]>
Signed-off-by: Alexander Piskun <[email protected]>
Signed-off-by: Alexander Piskun <[email protected]>
Signed-off-by: Alexander Piskun <[email protected]>
Signed-off-by: Alexander Piskun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because initially the project was written for a different AppAPI authentication, where all transmitted data was signed - there was a lot of unnecessary code left.
This pull request will cover it all, total refactoring and simplification of the code.
After this, it will be possible to make public methods for communicating with Nextcloud, which would make it easier to connect third-party packages.
It is also necessary to clean up the code before adding asynchronous methods.
Changes proposed in this pull request:
AUTHORIZATION-APP-API
header with help ofevent_hook
timeout
duringhttpx.adapter
creationbase_url
duringhttpx.adapter
creationsession.adapter.stream
(removed_session.get_stream
)_session.adapter_dav.XXX
(removed_session.dav
/_session.dav_stream
)_session.request
and_sessions.request_json
- instead directly callsession.adapter
response_headers
are now set with help ofhttpx.event_hooks