fix: WriteJson should write data as a JSON value when dataContentType… #1162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embano1
reviewed
May 28, 2025
|
Also, you need to |
duglin
reviewed
Jun 2, 2025
| @@ -165,7 +165,97 @@ func TestMarshal(t *testing.T) { | |||
| "source": "http://example.com/source", | |||
| }, | |||
| }, | |||
| "struct data v1.0": { | |||
| "structured mode data v1.0": { | |||
There was a problem hiding this comment.
Can you add a test that sends a string that just happens to look like json? Just to make sure it stays a string on both ends.
There was a problem hiding this comment.
Are you referring to this test case?
sdk-go/v2/event/event_marshal_test.go
Line 338 in d35a778
If so, it is already there and no regression (test still pass ✅ )
…=application/cloudevents+json (and batch) Signed-off-by: Alan Kan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…=application/cloudevents+json (and batch)
#1161