[Workers AI] Fix whisper param #22935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kodster28
requested review from
craigsdennis,
pedrosousa and
a team
as code owners
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
Comment on lines
+44
to
+45
| "type": "boolean", | ||
| "default": false, |
There was a problem hiding this comment.
Changing the 'vad_filter' property from a string type with a string default ('false') to a boolean type with a boolean default (false) is correct for schema accuracy. Please ensure that any client code or documentation referencing the old string type/value is updated accordingly to prevent integration issues.
Oxyjun
approved these changes
Jun 5, 2025
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
|
Preview URL: https://fe3098f5.preview.developers.cloudflare.com |
|
Hello Jun,
Thank you for the approval! If you have any further suggestions or feedback regarding the changes made in PR #22935, please feel free to share. Your insights are always valuable.
Sincerely,
Oxyjun
…-------- Orijinal E-posta-----------
İtibaren: Jun Lee ***@***.***>
Gönderilmiş: 5 Haziran 2025 18:05:16 GMT+03:00
İle: cloudflare/cloudflare-docs ***@***.***>
Bilgi: Subscribed ***@***.***>
Ders: Re: [cloudflare/cloudflare-docs] [Workers AI] Fix whisper param (PR #22935)
@Oxyjun approved this pull request.
--
Reply to this email directly or view it on GitHub:
#22935 (review)
You are receiving this because you are subscribed to this thread.
Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #22927 and fixes #22734