Skip to content

feat: hello world binding #9475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 11, 2025
Merged

feat: hello world binding #9475

merged 8 commits into from
Jun 11, 2025
+771 −2

Conversation

edmundhung
Copy link
Member

@edmundhung edmundhung commented Jun 4, 2025 •
edited
Loading

Fixes n/a.

This PR adds a hello world binding that serves as as an explanatory example.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: example binding
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: v4 only

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 4, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 1cf69ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
miniflare Patch
wrangler Patch
@cloudflare/pages-shared Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod workers-devprod added the e2e Run wrangler + vite-plugin e2e tests on a PR label Jun 4, 2025
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Jun 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025 •
edited
Loading

A Wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15469328926/npm-package-wrangler-9475
Prereleases for other packages:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15469328926/npm-package-cloudflare-workers-bindings-extension-9475 -O ./cloudflare-workers-bindings-extension.0.0.0-vd4045fca0.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vd4045fca0.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15469328926/npm-package-create-cloudflare-9475 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15469328926/npm-package-cloudflare-kv-asset-handler-9475

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15469328926/npm-package-miniflare-9475

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15469328926/npm-package-cloudflare-pages-shared-9475

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15469328926/npm-package-cloudflare-unenv-preset-9475

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15469328926/npm-package-cloudflare-vite-plugin-9475

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15469328926/npm-package-cloudflare-vitest-pool-workers-9475

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15469328926/npm-package-cloudflare-workers-editor-shared-9475

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15469328926/npm-package-cloudflare-workers-shared-9475

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15469328926/npm-package-cloudflare-workflows-shared-9475

Note that these links will no longer work once the GitHub Actions artifact expires.

@edmundhung edmundhung force-pushed the edmundhung/hello-world-binding branch from 48d4658 to 03ff12e Compare June 5, 2025 14:12
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 6, 2025 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9475

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9475

miniflare

npm i https://pkg.pr.new/miniflare@9475

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9475

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9475

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9475

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9475

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9475

wrangler

npm i https://pkg.pr.new/wrangler@9475

commit: 1cf69ef

@edmundhung edmundhung force-pushed the edmundhung/hello-world-binding branch 2 times, most recently from 2e476ed to 111a664 Compare June 6, 2025 15:15
@edmundhung edmundhung marked this pull request as ready for review June 6, 2025 15:25
@edmundhung edmundhung requested a review from a team as a code owner June 6, 2025 15:25
@edmundhung edmundhung changed the title draft: hello world binding feat: hello world binding Jun 6, 2025
@edmundhung edmundhung force-pushed the edmundhung/hello-world-binding branch from 111a664 to 330c5c0 Compare June 6, 2025 15:28
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main edmundhung/hello-world-binding might be a good starting point.

@edmundhung edmundhung added the skip-v3-pr Skip validation of presence of a v3 backport PR label Jun 6, 2025
@edmundhung edmundhung requested a review from penalosa June 9, 2025 10:01
penalosa
penalosa approved these changes Jun 9, 2025
View reviewed changes
packages/wrangler/src/config/validation.ts Outdated
return false;
}
let isValid = true;
// Secrets store bindings must have a binding, store_id, and secret_name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment seems out of date

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks! Updated in 3ed498a.

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 9, 2025
@edmundhung edmundhung force-pushed the edmundhung/hello-world-binding branch 2 times, most recently from d160418 to 97d7379 Compare June 11, 2025 13:42
@edmundhung edmundhung force-pushed the edmundhung/hello-world-binding branch from 97d7379 to 1cf69ef Compare June 11, 2025 15:13
@edmundhung edmundhung added this pull request to the merge queue Jun 11, 2025
Merged via the queue into main with commit 931f467 Jun 11, 2025
20 checks passed
@edmundhung edmundhung deleted the edmundhung/hello-world-binding branch June 11, 2025 16:03
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jun 11, 2025
@workers-devprod workers-devprod mentioned this pull request Jun 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penalosa penalosa penalosa approved these changes

Assignees
No one assigned
Labels
e2e Run wrangler + vite-plugin e2e tests on a PR skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
workers-sdk
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edmundhung @penalosa @workers-devprod