Add policies_last_updated endpoint to internal policy server #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrussett
suggested changes
Jul 25, 2023
src/code.cloudfoundry.org/policy-server/handlers/policies_last_updated_internal_test.go
Show resolved
Hide resolved
jrussett
approved these changes
Jul 26, 2023
jrussett
pushed a commit
to cloudfoundry/silk-release
that referenced
this pull request
Jul 26, 2023
This PR accompanies cloudfoundry/cf-networking-release#231 Vxlan policy agent first checks the last updated endpoint of policy server and if there was an update (new policy created or deleted) it will run the poll cycle and poll all policies for containers on Diego cell. It will also run poll cycle if getting policies returns an error for backwards compatibility with old policy servers. It only does this in the converger and not when forcing poll cycle during container creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
policies_last_updated endpoint can be used by policy agents to determine if they need to pull new policies.
This will help with resource consumption on database VM and overall traffic going through the system. Since policy agents default to polling policies every 5s this is especially visible as a problem in environments with hundreds of Diego cells and thousands of policies.
In this PR:
policies_infowith the fieldlast_updated. Fieldidis added as primary key because mysql percona complains that table must have a primary key.