Ruby 3.4 #4236
Ruby 3.4 #4236
Conversation
| @@ -1,7 +1,7 @@ | |||
| Sequel.migration do | |||
| change do | |||
| create_table :asg_timestamps do | |||
| primary_key name: :id | |||
| primary_key :id, name: :id | |||
There was a problem hiding this comment.
I think enough time has passed that we don't need to worry about someone having run this migration, but not the followup that corrected it. With Ruby 3.4, this migration would no longer behave consistently, anyway (name: id get serialized to {name: :id} instead of {:name=>:id})
There was a problem hiding this comment.
I initially tried to make these migrations more explicit, but that caused issues with the rename_column on MySQL 5.7 tests. Which we don't actually support, so a different potential workaround is dropping those tests.
There was a problem hiding this comment.
Is it worth just dropping 5.7 from the pipeline then?
* Skipping 3.3 due to bundler bug: rubygems/rubygems#8217
|
@sethboyles On which infrastructure providers did you test this already? You mention in the description possible issues with fog, so I guess we should test this on all the providers we support... |
|
@philippthun I only tested on singleton blobstore. The fog-local change ended up being minor, thankfully. But testing on other providers is a good idea... This might be a difficult now that we no longer have the blobstore-fanout, unfortunately. |
Seems like we might have to skip upgrading to Ruby 3.3 because it doesn't look like the default version of Bundler will get the bugfix we need. Trying to upgrade to Ruby 3.4 instead, but am running into more language change issues (particularly around keyword arguments).
We may have to update more fog gems: fog/fog-local#34
capi-release PR: cloudfoundry/capi-release#517
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests
Related PRs:
cloudfoundry/capi-release#517
cloudfoundry/capi-dockerfiles#57