-
Notifications
You must be signed in to change notification settings - Fork 365
Recreate Deployment Strategy #4396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Only unit tests created so far, will start implementing the feature to fix the tests. |
… recreate strategy Max in flight and canary steps are not valid options for the recreate deployment strategy
Ran the following scenarios: cf curl "/v3/deployments?app_guids=a25fa181-7983-4c02-a287-58275952869f" Rolled back to a previous droplet using recreate: Tried recreate with max-in-flight Tried recreate with canary steps |
Elect to use the deployment strategy of recreate
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
App developers can set Recreate deployment strategy in the API
An explanation of the use cases your change solves
With a default deployment strategy created users may like to elect to use the original deployment strategy of recreate
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
main
branchI have run all the unit tests using
bundle exec rake
I have run CF Acceptance Tests