Skip to content

Enhance multiple auth support and auth client #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Enhance multiple auth support and auth client #365

merged 1 commit into from
Dec 21, 2023

Conversation

ckganesan
Copy link
Contributor

@ckganesan ckganesan commented Dec 19, 2023

In this Pull Request, I've implemented enhancements to address a specific limitation:

  1. While the user password grant type previously supported only the default client (cf), it now accommodates the use of alternative clients, which was not possible before. Now we can achieve like below
config.New("https://api.cf.com", config.ClientCredentials('test', 'test'), config.UserPassword('test', 'test'))
  1. At present, duplication of the client request body occurs when utilizing bytes.Buffer, bytes.Reader, and strings.Reader.

  2. Reattempt the client request following the expiration of the refresh token.

  3. Eliminate the use of loops in implementing retry logic.

@sneal
Copy link
Contributor

sneal commented Dec 21, 2023

I'll go ahead and merge this, any clean up (which is minor) can be done later

@sneal sneal merged commit c36e653 into cloudfoundry:main Dec 21, 2023
@ckganesan ckganesan deleted the enhance-multiple-auth-support branch December 22, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants