Skip to content

fix(ttstream): metrics missing caused by server-side rpcinfo not set correctly #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DMwangnima
Copy link
Contributor

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@DMwangnima DMwangnima requested review from a team as code owners June 5, 2025 12:52
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 75.75758% with 8 lines in your changes missing coverage. Please review.

Project coverage is 60.37%. Comparing base (b3ca38d) to head (6ca6da9).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
pkg/remote/trans/ttstream/server_handler.go 74.19% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1787      +/-   ##
===========================================
- Coverage    60.44%   60.37%   -0.07%     
===========================================
  Files          379      379              
  Lines        34437    34438       +1     
===========================================
- Hits         20815    20793      -22     
- Misses       12364    12386      +22     
- Partials      1258     1259       +1     
Flag Coverage Δ
integration 48.27% <75.75%> (+<0.01%) ⬆️
unit 50.78% <60.60%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DMwangnima DMwangnima marked this pull request as draft June 9, 2025 07:19
@DMwangnima DMwangnima force-pushed the fix/ttstream_server_tracing branch 2 times, most recently from 9bcdd63 to 6eb3399 Compare June 9, 2025 07:21
@DMwangnima DMwangnima force-pushed the fix/ttstream_server_tracing branch from 6eb3399 to 6ca6da9 Compare June 9, 2025 13:20
@DMwangnima DMwangnima marked this pull request as ready for review June 9, 2025 13:29
@DMwangnima DMwangnima merged commit 07c5078 into cloudwego:develop Jun 10, 2025
67 of 90 checks passed
@DMwangnima DMwangnima deleted the fix/ttstream_server_tracing branch June 10, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants