-
Notifications
You must be signed in to change notification settings - Fork 5
(feat) AST -> HIR<TypedSpan> Conversion #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add map in HIR Add missing file Finish implementation of Map Integrate hashable maps Enrich call evaluate Add nothing type Almost done with engine operator field accesses Add logical & physical operator testing Rename nothing type into never Add metadata to Value Add try bind in context Add linked & unlinked UDF Preliminary from_ast conversion Add annotation support Advance more in conversation
6cee0d4
to
5c18333
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have time to read through all of the matching code, so I focused on just the type design.
Other than the stuff I mentioned about errors (and on slack about immutable contexts instead of a stack of history for every single context), everything generally looks good to me. I think the UDFs setup is a bit strange but given that you have nothing to work with yet (I still have to write all of the E2E structure for that) I think this is fine to merge and we can fix that later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Implements the first pass of AST->HIR conversion in
analyzer/from_ast
.In addition to obtaining a
HIR<TypedSpan>
, the conversion process:You may experiment with it as follows:
cargo run -- compile examples/example.dsl --print-ast --print-hir