fix(#4175): add conditions for notifier auto-configuration to check if admin server is enabled #4203
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikpetzold
reviewed
Apr 17, 2025
| @@ -74,6 +74,8 @@ | |||
| import de.codecentric.boot.admin.server.notify.filter.web.NotificationFilterController; | |||
|
|
|||
| @Configuration(proxyBeanMethods = false) | |||
| @Conditional(SpringBootAdminServerEnabledCondition.class) | |||
| @ConditionalOnBean(AdminServerMarkerConfiguration.Marker.class) | |||
There was a problem hiding this comment.
with the first condition, the second one should not be needed
…f admin server is enabled
SteKoe
force-pushed
the
fix/4175-mailsender-error-when-server-is-disabled
branch
from
67707a1 to
eb12044
Compare
erikpetzold
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4175