Update dependencies - PHP 8.1 - 8.4 #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Psalm released v6 just recently. That includes PHP 8.4 support. |
|
Oh... I hadn't noticed that. I worked on the changes over the weekend and the new version wasn't out then. Thanks - I'll send the changes tomorrow. |
datamweb
approved these changes
Jan 30, 2025
paulbalandan
approved these changes
Jan 30, 2025
samsonasik
approved these changes
Jan 31, 2025
|
Thank you everyone! |
datamweb
reviewed
Feb 13, 2025
| "roave/security-advisories": "dev-latest", | ||
| "vimeo/psalm": "^5.0" | ||
| "vimeo/psalm": "^6.0" |
There was a problem hiding this comment.
@michalsn The PHP version in CodeIgniter, DevKit, and other dependencies is defined as ^8.1, while vimeo/psalm version ^6 requires PHP 8.1.17 or higher. This mismatch causes the error.
PS I:\work\Github\shield> composer update
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.
Problem 1
- Root composer.json requires codeigniter4/devkit ^1.3 -> satisfiable by codeigniter4/devkit[v1.3.0].
- codeigniter4/devkit v1.3.0 requires vimeo/psalm ^6.0 -> satisfiable by vimeo/psalm[6.0.0, ..., 6.x-dev].
- vimeo/psalm[6.0.0, ..., 6.5.0] require php ~8.1.17 || ~8.2.4 || ~8.3.0 || ~8.4.0 -> your php version (8.1.10) does not satisfy that requirement.
- vimeo/psalm[6.5.1, ..., 6.x-dev] require php ~8.1.31 || ~8.2.27 || ~8.3.16 || ~8.4.3 -> your php version (8.1.10) does not satisfy that requirement.There was a problem hiding this comment.
Good catch. Would you like to send a fix to the devkit?
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates dependencies for use only with currently supported versions of PHP (8.1 - 8.4).
We still need to call composer with the--ignore-platform-reqsflag for PHP 8.4, as Psalm does not support it yet.Changes:
These changes should allow us to use devkit for projects that use PHP 8.4.
Checklist: