Update for CI 4.3.0

[kenjis]

CI v4.3.0 was released. So we need to update some code.

Some tests fail:

There were 9 errors:

1) Tests\Commands\UserModelGeneratorTest::testGenerateUserModelWithoutClassNameInput
ErrorException: stream_filter_append(): Unable to locate filter "CITestStreamFilter"

/Users/kenji/work/codeigniter/official/codeigniter-shield/tests/Commands/UserModelGeneratorTest.php:23

2) Tests\Commands\UserModelGeneratorTest::testGenerateUserModelCustomNamespace
ErrorException: stream_filter_append(): Unable to locate filter "CITestStreamFilter"

/Users/kenji/work/codeigniter/official/codeigniter-shield/tests/Commands/UserModelGeneratorTest.php:23

3) Tests\Commands\UserModelGeneratorTest::testGenerateUserModel
ErrorException: stream_filter_append(): Unable to locate filter "CITestStreamFilter"

/Users/kenji/work/codeigniter/official/codeigniter-shield/tests/Commands/UserModelGeneratorTest.php:23

4) Tests\Commands\UserModelGeneratorTest::testGenerateUserCannotAcceptShieldUserModelAsInput
ErrorException: stream_filter_append(): Unable to locate filter "CITestStreamFilter"

/Users/kenji/work/codeigniter/official/codeigniter-shield/tests/Commands/UserModelGeneratorTest.php:23

5) Tests\Commands\UserModelGeneratorTest::testGenerateUserModelWithSuffix
ErrorException: stream_filter_append(): Unable to locate filter "CITestStreamFilter"

/Users/kenji/work/codeigniter/official/codeigniter-shield/tests/Commands/UserModelGeneratorTest.php:23

6) Tests\Commands\UserModelGeneratorTest::testGenerateUserModelWithForce
ErrorException: stream_filter_append(): Unable to locate filter "CITestStreamFilter"

/Users/kenji/work/codeigniter/official/codeigniter-shield/tests/Commands/UserModelGeneratorTest.php:23

7) Tests\Commands\SetupTest::testRun
ErrorException: stream_filter_append(): Unable to locate filter "CITestStreamFilter"

/Users/kenji/work/codeigniter/official/codeigniter-shield/tests/Commands/SetupTest.php:25

8) Tests\Unit\UserModelTest::testUpdateUserArrayWithUserDataToUpdate
CodeIgniter\Database\Exceptions\DatabaseException: Updates are not allowed unless they contain a "where" or "like" clause.

/Users/kenji/work/codeigniter/official/codeigniter-shield/vendor/codeigniter4/framework/system/Model.php:390
/Users/kenji/work/codeigniter/official/codeigniter-shield/vendor/codeigniter4/framework/system/BaseModel.php:943
/Users/kenji/work/codeigniter/official/codeigniter-shield/vendor/codeigniter4/framework/system/Model.php:754
/Users/kenji/work/codeigniter/official/codeigniter-shield/src/Models/UserModel.php:273
/Users/kenji/work/codeigniter/official/codeigniter-shield/tests/Unit/UserModelTest.php:212

9) Tests\Unit\UserModelTest::testUpdateUserObjectWithUserDataToUpdate
CodeIgniter\Database\Exceptions\DatabaseException: Updates are not allowed unless they contain a "where" or "like" clause.

/Users/kenji/work/codeigniter/official/codeigniter-shield/vendor/codeigniter4/framework/system/Model.php:390
/Users/kenji/work/codeigniter/official/codeigniter-shield/vendor/codeigniter4/framework/system/BaseModel.php:943
/Users/kenji/work/codeigniter/official/codeigniter-shield/vendor/codeigniter4/framework/system/Model.php:754
/Users/kenji/work/codeigniter/official/codeigniter-shield/src/Models/UserModel.php:273
/Users/kenji/work/codeigniter/official/codeigniter-shield/tests/Unit/UserModelTest.php:176

--

There were 8 failures:

1) Tests\Controllers\LoginTest::testLoginActionUsernameSuccess
Failed asserting that 1489104000 is identical to 1489125600.

/Users/kenji/work/codeigniter/official/codeigniter-shield/tests/Controllers/LoginTest.php:161

2) Tests\Controllers\LoginTest::testLoginActionEmailSuccess
Failed asserting that 1489104000 is identical to 1489125600.

/Users/kenji/work/codeigniter/official/codeigniter-shield/tests/Controllers/LoginTest.php:93

3) Tests\Authentication\Filters\TokenFilterTest::testFiltersProtectsWithScopes
Failed asserting that CodeIgniter\I18n\Time Object &0000000000000a0c0000000000000000 (
    'timezone' => 'America/Chicago'
    'locale' => 'en'
    'toStringFormat' => 'yyyy-MM-dd HH:mm:ss'
    'date' => '2017-03-10 00:00:00.000000'
    'timezone_type' => 3
) is greater than CodeIgniter\I18n\Time Object &0000000000000b4a0000000000000000 (
    'timezone' => 'UTC'
    'locale' => 'en'
    'toStringFormat' => 'yyyy-MM-dd HH:mm:ss'
    'date' => '2017-03-10 06:00:00.000000'
    'timezone_type' => 3
).

/Users/kenji/work/codeigniter/official/codeigniter-shield/tests/Authentication/Filters/TokenFilterTest.php:81

4) Tests\Authentication\Filters\TokenFilterTest::testRecordActiveDate
Failed asserting that CodeIgniter\I18n\Time Object &0000000000000a970000000000000000 (
    'timezone' => 'America/Chicago'
    'locale' => 'en'
    'toStringFormat' => 'yyyy-MM-dd HH:mm:ss'
    'date' => '2017-03-10 00:00:00.000000'
    'timezone_type' => 3
) is greater than CodeIgniter\I18n\Time Object &0000000000000aaf0000000000000000 (
    'timezone' => 'UTC'
    'locale' => 'en'
    'toStringFormat' => 'yyyy-MM-dd HH:mm:ss'
    'date' => '2017-03-10 06:00:00.000000'
    'timezone_type' => 3
).

/Users/kenji/work/codeigniter/official/codeigniter-shield/tests/Authentication/Filters/TokenFilterTest.php:64

5) Tests\Authentication\Filters\SessionFilterTest::testRecordActiveDate
Failed asserting that CodeIgniter\I18n\Time Object &0000000000000a710000000000000000 (
    'timezone' => 'America/Chicago'
    'locale' => 'en'
    'toStringFormat' => 'yyyy-MM-dd HH:mm:ss'
    'date' => '2017-03-10 00:00:00.000000'
    'timezone_type' => 3
) is greater than CodeIgniter\I18n\Time Object &0000000000000cde0000000000000000 (
    'timezone' => 'UTC'
    'locale' => 'en'
    'toStringFormat' => 'yyyy-MM-dd HH:mm:ss'
    'date' => '2017-03-10 06:00:00.000000'
    'timezone_type' => 3
).

/Users/kenji/work/codeigniter/official/codeigniter-shield/tests/Authentication/Filters/SessionFilterTest.php:58

6) Tests\Authentication\MagicLinkTest::testMagicLinkVerifySuccess
Redirect URL `https://example.com/index.php` does not match `https://example.com/index.php/login/magic-link`
Failed asserting that false is true.

/Users/kenji/work/codeigniter/official/codeigniter-shield/vendor/codeigniter4/framework/system/Test/TestResponse.php:212
/Users/kenji/work/codeigniter/official/codeigniter-shield/tests/Authentication/MagicLinkTest.php:137

7) Tests\Controllers\MagicLinkTest::testMagicLinkVerifyPendingRegistrationActivation
Redirect URL `/auth/a/show` does not match `https://example.com/index.php/login/magic-link`
Failed asserting that false is true.

/Users/kenji/work/codeigniter/official/codeigniter-shield/vendor/codeigniter4/framework/system/Test/TestResponse.php:212
/Users/kenji/work/codeigniter/official/codeigniter-shield/tests/Controllers/MagicLinkTest.php:102

8) Tests\Authentication\Authenticators\SessionAuthenticatorTest::testLogout
Failed asserting that a row in the table [auth_remember_tokens] matches the attributes 
{
    "user_id": 1
}

Found: [].

/Users/kenji/work/codeigniter/official/codeigniter-shield/vendor/codeigniter4/framework/system/Test/DatabaseTestTrait.php:280
/Users/kenji/work/codeigniter/official/codeigniter-shield/tests/Authentication/Authenticators/SessionAuthenticatorTest.php:177

ERRORS!
Tests: 286, Assertions: 594, Errors: 9, Failures: 8.
Script phpunit handling the test event returned with error code 2

[jozefrebjak]

@kenjis I have also problem in my project with PHPStan error related to the service('auth')->routes($routes);,

Error thrown in /app/modules/Auth/Config/Routes.php on line 10 while loading bootstrap file /app/vendor/codeigniter4/framework/system/Test/bootstrap.php: Call to a member function routes() on null

$routes was removed from bootstrap as I can see.

[kenjis]

@jozefrebjak Why service('auth') is null?

[jozefrebjak]

@kenjis

service('auth') is not null, but somehow bootstrap is failing with PHPStan and this line.

[jozefrebjak]

save() does not work anymore:

mysqli_result::fetch_object(): Argument #1 ($class) must be a valid class name, App\Entity\UserEntity given

For me no problem with save().

[jozefrebjak]

save() does not work anymore:
mysqli_result::fetch_object(): Argument #1 ($class) must be a valid class name, App\Entity\UserEntity given

For me no problem with save().

Even shield default registration fails.

I have no problem with registration.

[shindupratama]

2 days ago, shield is working fine, but today when I redirect to /login or /register, I got an error " preg_match(): Unknown modifier 'b' " in vendor/codeigniter4/framework/system/Router/Router.php at line 418

Anyone got the same error ?

[datamweb]

Anyone got the same error ?

@shindupratama Hi,
We have no error. We don't know if you have updated or not, which version you have used, if you have custom definition route or not, if you have used filters or not.

If you think there is a bug, please reproduce it, and send us all the steps in a report for review.

[datamweb]

@kenjis, anything else left? if not please close.