Support for different prompt types #24
Open
+13
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n prompt shows, had to make sure that setSelectionRange doesn't get run on anything but text, password, and url inputs
|
Could you please run |
|
Should work fine on desktop browsers too, the only difference with desktop browsers is they won't see a customised on-screen keyboard but it will still limit what can be put into the prompt input field. As for tests, I have no clue how to do them, and looking at the test/smalltalk.js file, it's kinda way over my head :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have added support for date, email, number, and tel prompts in addition to the original password prompt.
Had to make it so that setSelectionRange would only happen if it was a password, text, or url input field otherwise it errors out.
Probably better ways to do some of it, but it works for my use case on a Honeywell CT60 Android barcode scanner.