Skip to content

Remove need for '-' flag to force stdin #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 13, 2017
Merged

Conversation

codingo
Copy link
Owner

@codingo codingo commented Oct 11, 2017

This patch removes the need for the '-' flag when using stdin and instead allows you to pipe into VHostScan directly at anytime. STDIN is checked prior to a commit.

Tested already on a Windows VM but still requires testing in Kali.

@timkent
Copy link
Collaborator

timkent commented Oct 12, 2017

It seems to work well but now it includes the wordlist as well as the stdin list. I assume this is not the desired result?

@codingo
Copy link
Owner Author

codingo commented Oct 12, 2017

I can replicate it, this is the relevant code block:

    default_wordlist = DEFAULT_WORDLIST_FILE \
        if not sys.stdin.isatty() else None

Will look to resolve in the next couple of days unless you have a chance to patch!

@codingo
Copy link
Owner Author

codingo commented Oct 12, 2017

Ignore the above - once I posted that I realised it was just in the reverse. Could you please re-test @timkent? The following would ensure good coverage:

  1. STDIN only
  2. STDIN + wordlist
  3. No STDIN, default wordlist
  4. No STDIN, provided wordlist

I'll look at making an automated test case for this area once we've merged this branch.

@timkent
Copy link
Collaborator

timkent commented Oct 13, 2017

Looks good, I have tested those scenarios.

Minor filename fix
Copy link
Collaborator

@timkent timkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good

@timkent timkent merged commit bf35484 into master Oct 13, 2017
@codingo codingo deleted the codingo-stdin-improvements branch October 13, 2017 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants