fix ch11-01-writing-tests: remove duplicate paragraph #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iampi31415
reviewed
Jun 21, 2025
|
line 105, below the benchmark tests paragraph |
|
Can you simply copy and paste the line that is duplicated ? @0x766F6964 |
|
Yes, that's correct. Given that there isn't a diff highlighting the dup is was hard to find by simply reading. Also, that's not in the upstream book, so updating it won't fix it. I hope they merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The paragraph about filtering tests out with matching test names with strings is duplicated, remove one of those paragraphs.