Skip to content

Relax gemspec to allow Rails 8.1 #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

BranLiang
Copy link
Contributor

Rails main is at 8.1 now, since we have test coverage for rails main branch already, it should be safe to allow rails 8.1 to install. Otherwise people using edge rails will install legacy 4.2.2 version, which doesn't work well.

@aitor
Copy link

aitor commented Nov 8, 2024

@mattbrictson @danielmorrison although the support for Rails 8 was added in the changelog as included in release 5.7.0, the relevant changes added in #717 were reverted before cutting the gem in this commit 7b7a9de

image

That makes merging this PR important as the current published version is not compatible with the final 8.0 rails version released yesterday.

@mattbrictson
Copy link
Contributor

Yes, sorry about that. The current main branch has all the changes and gemspec updates necessary to support Rails 8.0, it's just that a new release has not been cut. I'm not a maintainer so I can't help there, but in the meantime you can update your Gemfile as follows:

gem "audited", github: "collectiveidea/audited", branch: "main"

I realize not all teams have the flexibility to point to a non-release version, so hopefully a maintainer of this project will be able to cut a new official release soon.

@aitor
Copy link

aitor commented Nov 8, 2024

Yes, sorry about that. The current main branch has all the changes and gemspec updates necessary to support Rails 8.0

No prob! I know you can point to main but I think a lot of people will be updating their gemfiles in the coming days and will be a better experience if 5.7.1 is cut.

Thank you and hope a maintainer can make a new release soon!

@danielmorrison danielmorrison merged commit b658e95 into collectiveidea:main Nov 8, 2024
82 checks passed
@Faq
Copy link

Faq commented Apr 6, 2025

Seems You forgot to update also readme with Rails 8.0 support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants