Skip to content

[KIP-554] User SCRAM credentials API #2070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Jul 12, 2023
Merged

[KIP-554] User SCRAM credentials API #2070

merged 39 commits into from
Jul 12, 2023

Conversation

mahajanadhitya
Copy link
Contributor

No description provided.

anchitj
anchitj suggested changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@anchitj anchitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests are failing. Can we fix that as well please?

@anchitj
Copy link
Contributor

anchitj commented Jul 6, 2023

Tried running the tests locally but they seem to be getting stuck indefinitely. Can you please check?

anchitj
anchitj reviewed Jul 7, 2023
View reviewed changes
anchitj
anchitj suggested changes Jul 7, 2023
View reviewed changes
anchitj
anchitj suggested changes Jul 7, 2023
View reviewed changes
anchitj
anchitj reviewed Jul 7, 2023
View reviewed changes
@anchitj
Copy link
Contributor

anchitj commented Jul 7, 2023

Also add a CHANGELOG entry

emasab added 4 commits July 7, 2023 19:26
@emasab
Reflect librdkafka changes
37ca319 
Add exceptions
Remove AlterUserScramCredentialsResult
Add DescribeUserScramCredentialsReport
@emasab
Fixes and parametric examples
3689297
@emasab
Fix integration tests
e07bdd8
@emasab
Better exception documentation
108e486
anchitj
anchitj reviewed Jul 10, 2023
View reviewed changes
Copy link
Contributor

@anchitj anchitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified all the integration tests are passing against feature/userscram-AdminClient librdkafka.

@emasab emasab changed the title Feature/admin client scramapi [KIP-554] User SCRAM credentials API Jul 10, 2023
anchitj
anchitj approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@anchitj anchitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just need to add changelog before merging.

anchitj
anchitj approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@anchitj anchitj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests. LGTM. Probably needs a rebase with the master as it's showing conflict in the CHANGELOG.

@anchitj anchitj merged commit 39f4206 into master Jul 12, 2023
@anchitj anchitj deleted the feature/AdminClient-SCRAMAPI branch July 12, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emasab emasab emasab left review comments

@anchitj anchitj anchitj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mahajanadhitya @anchitj @emasab