Use object mapping when serializing #2088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and deserializing with referenced schemas.
anchitj
reviewed
Jul 28, 2023
Comment on lines
+149
to
+158
| var jsonSchemaGeneratorSettings = new JsonSchemaGeneratorSettings | ||
| { | ||
| SerializerSettings = new JsonSerializerSettings | ||
| { | ||
| ContractResolver = new DefaultContractResolver | ||
| { | ||
| NamingStrategy = new CamelCaseNamingStrategy() | ||
| } | ||
| } | ||
| }; |
There was a problem hiding this comment.
Is the user always supposed to provide this? Won't it make sense that we keep this as default JsonSchemaGeneratorSettings for both JsonSerializer and JsonDeserializer if the user isn't providing any JsonSchemaGeneratorSettings?
There was a problem hiding this comment.
It's not required to provide this, this allows you to set the default strategy and avoid to add attributes like
[JsonProperty("favoriteColor")] to the fields, but that is also possible. I'd not change JsonSerializer defaults, also it would be a breaking change (see PersonPoco in tests).
I can add a comment about this.
|
|
anchitj
added a commit
that referenced
this pull request
Aug 25, 2023
* jsonserialisation with references support * json deserialiser with validation against a passed schema * changes to reference resolver, using AddSchema * integration test added for JSON with references * "commit cleanup (1)" * "commit cleanup(2)" * "removed error: same reference used elsewhere" * "changes to sln file and Version" * commit cleanup (3) * NonGenericJsonSerializer added, along with Convertor in JsonDeserializer * added check for int enum while adding ref schema * added unit test for schema w json ref SerDes * moved schema resolution to separate utils class * changes as per review comments * after review changes * changerlogs updated * Use object mapping when serializing (#2088) * Use object mapping when serializing and deserializing with referenced schemas. * Test producing and consumer JObject * Rename JsonSerDesSchemaUtils to JsonSchemaResolver * Copyright * Documentation * Fix unit tests * Add comment about NJson mapping * Fix CHANGELOG --------- Co-authored-by: Emanuele Sabellico <[email protected]> Co-authored-by: Anchit Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and deserializing with referenced schemas.