fix(auth): do auth dance even when basic auth creds are not found #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I remove the
found
condition from the if statement around the auth dances performed to fetch a token from the registry auth server. This condition required that the user provide basic auth creds in their initial request only for those creds to then fail on the initial request, with a 401 response sent back and awww-authenticate
header instructing the client to fetch a token from the auth server. Some registries (such asghcr.io
) require this dance for all clients regardless of whether the image is public or private. Removing this condition seems to work now for publicghcr.io
images.For reference, see: