Skip to content

override HealthChecks fields embeded in container image #20220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

override HealthChecks fields embeded in container image #20220

wants to merge 1 commit into from

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Sep 30, 2023 •
edited
Loading

Fixes: #20212

Does this PR introduce a user-facing change?

Users can now override HealthCheck information provided via container images.

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Sep 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2023
@rhatdan rhatdan changed the title Allow overriding of fields in HealthChecks embeded within a container… override HealthChecks fields embeded in container image Sep 30, 2023
@openshift-ci openshift-ci bot added release-note and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Sep 30, 2023
@packit-as-a-service
Copy link

Cockpit tests failed for commit 2ab53b246d4ba753e36bf83e0bd0762e34eff2c9. @martinpitt, @jelly, @mvollmer please check.

@packit-as-a-service
Copy link

Cockpit tests failed for commit 5571012a703c8a9fc37751ee0de9e8bcd7d52f00. @martinpitt, @jelly, @mvollmer please check.

@packit-as-a-service
Copy link

Cockpit tests failed for commit 2ab53b246d4ba753e36bf83e0bd0762e34eff2c9. @martinpitt, @jelly, @mvollmer please check.

@packit-as-a-service
Copy link

Cockpit tests failed for commit 5571012a703c8a9fc37751ee0de9e8bcd7d52f00. @martinpitt, @jelly, @mvollmer please check.

@packit-as-a-service
Copy link

Cockpit tests failed for commit e8cf0ce9b209935b28fd4631e6663401fc26f71d. @martinpitt, @jelly, @mvollmer please check.

@packit-as-a-service
Copy link

Cockpit tests failed for commit 09d442652642062c09a04736ab74f1633d3331ef. @martinpitt, @jelly, @mvollmer please check.

flouthoc
flouthoc reviewed Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests don't look happy.

@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Nov 2, 2023
@packit-as-a-service Packit-as-a-Service
Copy link

Cockpit tests failed for commit c5799e2101d18e60ac7eaaaca0a73a34c66f5a6a. @martinpitt, @jelly, @mvollmer please check.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2023

A friendly reminder that this PR had no activity for 30 days.

@rhatdan rhatdan closed this May 15, 2024
@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@packit-as-a-service Packit-as-a-Service
Copy link

Cockpit tests failed for commit 6408a05. @martinpitt, @jelly, @mvollmer please check.

@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 14, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flouthoc flouthoc flouthoc left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Change to remote API; merits scrutiny locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note stale-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Healthcheck interval command line options ignored if set in Containerfile
2 participants
@rhatdan @flouthoc