-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add support for Retry= and RetryDelay= to Podman Quadlet. #25675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
image and build units also should accept these options for consistency.
$ podman build --help | grep retry
--retry int number of times to retry in case of failure when performing push/pull (default 3)
--retry-delay string delay between retries in case of push/pull failures
$ podman pull --help | grep retry
--retry uint number of times to retry in case of failure when performing pull (default 3)
--retry-delay string delay between retries in case of pull failures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small doc nit
Thanks, that's a good point. I've added them in the latest update :-). |
But checking that PR once more, I did not add documentation for them, will add it :-). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, just missing the last doc part
This commit adds new Retry= and RetryDelay= options to quadlet.go which result in --retry and --retry-delay usage in podman run, image and build commands. This allows configuring the retry logic in the systemd files. Fixes: containers#25109 Signed-off-by: Jan Kaluza <[email protected]>
Added the documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jankaluza, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8d693d6
into
containers:main
This commit adds new Retry= and RetryDelay= options to quadlet.go which result in --retry and --retry-delay usage in podman run command.
This allows configuring the retry logic in .container systemd files.
Fixes: #25109
Does this PR introduce a user-facing change?