-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[WIP]Update storage.conf location doc #25760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
As per [1], `XDG_CONFIG_HOME` is attempted first [1] https://github.com/containers/storage/blob/f1c4bdf1d7c1c046349d5862214e1e3580bafd00/types/utils.go#L41-L43 Signed-off-by: Lewis Denny <[email protected]>
becdb7b
to
382ec5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM.
/approve
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Honny1, ninja-quokka The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is correct but makes these docs inconsistent, all config files here are mentioned with $HOME/.config/...
here but at least containers.conf will also prefer XDG_CONFIG_HOME.
So as user it would be confusing why this is mentioned for only for storage.conf.
I agree, are you happy if I update the others as well? The documentation is a little fragmented sadly but IMO if we are going to mention the location of the file, we should be 100% correct about it. |
Yes, but not all files actually use XDG_CONFIG_HOME, containers/image#2297 containers/image#1647. So this needs to be doubled checked against the code first. |
For sure, I will double check in the code to be sure like I did with this patch. I'll update this one tomorrow, thanks for the review! /hold |
A friendly reminder that this PR had no activity for 30 days. |
As per [1],
XDG_CONFIG_HOME
is attempted first[1] https://github.com/containers/storage/blob/f1c4bdf1d7c1c046349d5862214e1e3580bafd00/types/utils.go#L41-L43
Does this PR introduce a user-facing change?