Skip to content

[WIP]Update storage.conf location doc #25760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ninja-quokka
Copy link
Collaborator

As per [1], XDG_CONFIG_HOME is attempted first

[1] https://github.com/containers/storage/blob/f1c4bdf1d7c1c046349d5862214e1e3580bafd00/types/utils.go#L41-L43

Does this PR introduce a user-facing change?

None

Copy link
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

/approve

Copy link
Contributor

openshift-ci bot commented Apr 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Honny1, ninja-quokka
Once this PR has been reviewed and has the lgtm label, please assign giuseppe for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is correct but makes these docs inconsistent, all config files here are mentioned with $HOME/.config/... here but at least containers.conf will also prefer XDG_CONFIG_HOME.
So as user it would be confusing why this is mentioned for only for storage.conf.

@ninja-quokka
Copy link
Collaborator Author

That is correct but makes these docs inconsistent, all config files here are mentioned with $HOME/.config/... here but at least containers.conf will also prefer XDG_CONFIG_HOME. So as user it would be confusing why this is mentioned for only for storage.conf.

I agree, are you happy if I update the others as well? The documentation is a little fragmented sadly but IMO if we are going to mention the location of the file, we should be 100% correct about it.

@Luap99
Copy link
Member

Luap99 commented Apr 2, 2025

I agree, are you happy if I update the others as well?

Yes, but not all files actually use XDG_CONFIG_HOME, containers/image#2297 containers/image#1647. So this needs to be doubled checked against the code first.

@ninja-quokka
Copy link
Collaborator Author

I agree, are you happy if I update the others as well?

Yes, but not all files actually use XDG_CONFIG_HOME, containers/image#2297 containers/image#1647. So this needs to be doubled checked against the code first.

For sure, I will double check in the code to be sure like I did with this patch. I'll update this one tomorrow, thanks for the review!

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2025
@baude baude changed the title Update storage.conf location doc [WIP]Update storage.conf location doc Apr 2, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2025
Copy link

github-actions bot commented May 3, 2025

A friendly reminder that this PR had no activity for 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none stale-pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants