Fix machine e2e tests to pass on ARM64 Windows too #26176
Conversation
openshift-ci
bot
added
release-note-none
approved
pkg/machine/e2e/basic_test.go
Outdated
| @@ -113,7 +113,7 @@ var _ = Describe("run basic podman commands", func() { | |||
| Expect(err).ToNot(HaveOccurred()) | |||
| Expect(volumeCreate).To(Exit(0)) | |||
|
|
|||
| run, err := mb.setCmd(bm.withPodmanCommand([]string{"run", "-v", "a:/test:Z", "quay.io/libpod/alpine_nginx", "true"})).run() | |||
| run, err := mb.setCmd(bm.withPodmanCommand([]string{"run", "-v", "a:/test:Z", "quay.io/libpod/alpine", "true"})).run() | |||
There was a problem hiding this comment.
please use TESTIMAGE instead of yet another image that is not well maintained
There was a problem hiding this comment.
Thank you. I have updated that (cc @axel7083)
Signed-off-by: Mario Loriedo <[email protected]>
The image quay.io/libpod/alpine_nginx doesn't have a `linux/arm64` version and the test "Single character volume mount" on Windows ARM64 was failing. Changing it to TESTIMAGE (quay.io/libpod/testimage) fixes it. Signed-off-by: Mario Loriedo <[email protected]>
The podman machine copy test "attempt copying file to a new directory" was failing because on recent version of Windows the error message doesn't match the expected error message. To make it work on new and old version of Windows both old and new error messages are now considered as valid. Fixes containers#26056 Signed-off-by: Mario Loriedo <[email protected]>
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
1 similar comment
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
|
Can confirm that this fixed issues with Windows 2025 server runners |
|
@containers/podman-maintainers PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, l0rd, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
A couple of e2e tests were failing on ARM64 Windows. This PR provides the fixes.
Fix #26056
Does this PR introduce a user-facing change?