vendor: update docker, common, image, storage and buildah #26288
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
github-actions
bot
added
the
kind/api-change
Luap99
added
the
bloat_approved
Two incomptable changes, they removed the BridgeNfIP6tables and BridgeNfIptables fields so we must drop them. As they are not important ones that should not cause problems. Second, they moved to using DockerOCIImageConfig from another new module. The json format did not chnage so this is not an external API break. Signed-off-by: Paul Holzinger <[email protected]>
Signed-off-by: Paul Holzinger <[email protected]>
Includes one breaking change for the flag as BuildOutputs now accept a slice. Signed-off-by: Paul Holzinger <[email protected]>
Newer versions expect to use a new test helper. Signed-off-by: Nalin Dahyabhai <[email protected]> Signed-off-by: Paul Holzinger <[email protected]>
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
The buildah test code chnages so I had to manually resolve the conflict. Signed-off-by: Paul Holzinger <[email protected]>
The --output option is not supported with remote. Signed-off-by: Paul Holzinger <[email protected]>
| Entrypoint: info.Config.Entrypoint, | ||
| Labels: info.Labels, | ||
| StopSignal: info.Config.StopSignal, | ||
| }, |
There was a problem hiding this comment.
info can include healthcheck infornation information, and config can, too. Should it be added here?
There was a problem hiding this comment.
well my goal is to update the vendor code, if there are new api fields to show/explore that is part of the work @inknos is doing right now I assume he would pick it up eventually when we get around to the right API versions.
For now I rather not alter the output just like that.
|
LGTM |
|
/lgtm |
openshift-merge-bot
bot
merged commit 246a688
into
containers:main
Some breaking changes that we must handle manually.
Does this PR introduce a user-facing change?