feat: [EXT-2183] get-management-token #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelz
reviewed
Oct 2, 2020
|
|
||
| mkdir -p keys | ||
|
|
||
| openssl req -x509 -newkey rsa:4096 -nodes -batch -noout -keyout keys/key.pem |
There was a problem hiding this comment.
Would be nice to use generation in the API so we cover it with the tests too.
There was a problem hiding this comment.
Sorry, forgot to reply to this. I would like to do that in a followup, when also CI is in place
shikaan
force-pushed
the
feat/get-management-token
branch
from
29fb44d to
63b37fa
Compare
|
I have rotated the keys and removed the |
jelz
approved these changes
Oct 2, 2020
|
|
||
| mkdir -p keys | ||
|
|
||
| openssl req -x509 -newkey rsa:4096 -nodes -batch -noout -keyout keys/key.pem |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
ghost
added
the
hwartig
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.