Skip to content

Limit and Truncate Grep Search output #6206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 21, 2025
Merged

Limit and Truncate Grep Search output #6206

merged 10 commits into from
Jun 21, 2025

Conversation

RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Jun 20, 2025

Description

  • Adds a maxResults option to IDE getSearchResults methods
  • Implements this for the Grep Tool and search context provider
    • I decided on 100 results by default for agent AND 4500 truncation limit, with an additional warning context item in the case of truncation. This seems to work well
    • Updates the grep tool description to prompt it to be a bit more targeted with its queries
    • I made the Search context provider a bit more liberal since the user is choosing the query, with a default of 200 results, configurable with maxResults context block param, and no hard character limit
  • Adds unit tests for grep output formatting
  • Updates the docs and config schema

@RomneyDa RomneyDa requested a review from a team as a code owner June 20, 2025 00:46
@RomneyDa RomneyDa requested review from tomasz-stefaniak and removed request for a team June 20, 2025 00:46
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 20, 2025
Copy link

netlify bot commented Jun 20, 2025

Deploy Preview for continuedev ready!

Name Link
🔨 Latest commit 275c903
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/6854c4209029740008b067b4
😎 Deploy Preview https://deploy-preview-6206--continuedev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

recurseml bot commented Jun 20, 2025

⚠️ Only 5 files will be analyzed due to processing limits.

Copy link

recurseml bot commented Jun 20, 2025

✨ No issues found! Your code is sparkling clean! ✨

@RomneyDa RomneyDa requested review from sestinj and removed request for tomasz-stefaniak June 20, 2025 22:56
Copy link
Contributor

@sestinj sestinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great. we talked about this, so I won't repeat the whole logic around why this lgtm. good tests

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jun 21, 2025
@sestinj sestinj merged commit 75d351a into main Jun 21, 2025
37 checks passed
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 21, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jun 21, 2025
@sestinj sestinj deleted the dallin/limit-grep-output branch June 21, 2025 01:42
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants