Skip to content

grubconfig: create boot/grub2/grubenv if not existing #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2025
Merged

grubconfig: create boot/grub2/grubenv if not existing #931

merged 2 commits into from
May 28, 2025

Conversation

HuijingHei
Copy link
Member

Fixes #746

@HuijingHei HuijingHei force-pushed the add-grubenv branch 4 times, most recently from 792b88c to f6de524 Compare May 19, 2025 07:12
travier
travier approved these changes May 19, 2025
View reviewed changes
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I haven't tested this however and I'm not sure how we could do that easily.

@travier
Copy link
Member

travier commented May 19, 2025 

---- grubconfigs::tests::test_write_grubenv stdout ----
Error: Create /boot/grub2/grubenv

Caused by:
    No such file or directory (os error 2)

travier
travier reviewed May 19, 2025
View reviewed changes
@HuijingHei HuijingHei force-pushed the add-grubenv branch 3 times, most recently from 774c391 to 32c278b Compare May 20, 2025 09:52
@HuijingHei
Copy link
Member Author

LGTM. I haven't tested this however and I'm not sure how we could do that easily.

Agree, not easy. If using bootc install, it will by default install both BIOS and UEFI.

Just build bootupd and add as layered based on fedora-bootc:42, push to quay.io, then use anaconda to install from network with ostreecontainer --url quay.io/hhei/bootc-test and UEFI firmware, check we can get /boot/grub2/grubenv

[root@fedora ~]# ls /boot/grub2/grubenv 
/boot/grub2/grubenv

@HuijingHei HuijingHei force-pushed the add-grubenv branch 2 times, most recently from 144c5e0 to 4fdc0d3 Compare May 22, 2025 06:01
@HuijingHei
Copy link
Member Author

HuijingHei commented May 22, 2025 •
edited
Loading

@travier I update command .run() to .run_with_cmd_context(), and this can get more info if failed, also rebase the main branch. Could you help to review again? Thanks!

@HuijingHei HuijingHei force-pushed the add-grubenv branch 2 times, most recently from 7923373 to 4fdc0d3 Compare May 26, 2025 09:28
@HuijingHei HuijingHei merged commit f2c8d4c into coreos:main May 28, 2025
12 checks passed
@HuijingHei HuijingHei deleted the add-grubenv branch May 28, 2025 08:35
@HuijingHei
Copy link
Member Author

Thank you @travier for the kind review!

@travier travier mentioned this pull request May 28, 2025
Closed
dustymabe
dustymabe reviewed May 28, 2025
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustymabe dustymabe dustymabe left review comments

@travier travier travier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bootupd installation is missing /boot/grub2/grubenv
3 participants
@HuijingHei @travier @dustymabe