kolaTestIso: retry failed tests #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustymabe
requested review from
jlebon,
ravanelli,
mike-nguyen and
gursewak1997
as code owners
We've been seeing a lot of testiso flakes lately. Let's try to give ourselves a break by retrying like we do for normal kola runs. This is slightly different because it's not done inside kola but outside kola. For the inside kola retry of testiso we'll wait for coreos/coreos-assembler#3989 to happen.
I don't think this is needed anymore with [1]. See [2] [3]. [1] containers/podman#23847 [2] containers/podman#17452 [3] containers/podman#23831
dustymabe
force-pushed
the
dusty-retry-testiso
branch
from
434451e to
74be4a6
Compare
|
So for the life of me I don't understand it but there hasn't been a testiso failure (and thus falling through to hit this retry code) once since I switched the pipeline over to use my branch (to test this). Thoughts on just merging it (so we can switch the pipeline back to not using my fork) and then if it really is broken we'll PR a fixup? |
|
That works for me. It's either that or switch the pipeline back now to see if the tests start failing again. I'm all for merging this now though. |
aaradhak
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been seeing a lot of testiso flakes lately. Let's try to give ourselves a break by retrying like we do for normal kola runs.
This is slightly different because it's not done inside kola but outside kola. For the inside kola retry of testiso we'll wait for coreos/coreos-assembler#3989 to happen.