jobs/kola-azure: run kola tests on new Gen2 Gallery Images #1153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustymabe
reviewed
May 29, 2025
jobs/kola-azure.Jenkinsfile
Outdated
| --azure-location $region \ | ||
| --image-name $azure_image_name \ | ||
| --resource-group $azure_testing_resource_group \ | ||
| --azure-hyper-v-generation "V2" \ |
There was a problem hiding this comment.
No longer needed?
Suggested change
| --azure-hyper-v-generation "V2" \ |
There was a problem hiding this comment.
ah! thanks, copy/paste error when I was reworking the job. I'll remove it
marmijo
changed the title
Modify the job to build Hyper-V Gen2 gallery images and run kola tests exclusively on those new images[1]. The new Azure NVMe test[2] requires NVMe support, which is only available with Gen2 gallery images. Since there are no constraints requiring Gen1 images, we simplify things by testing only Gen2. A pipeline config variable, `test_gallery`, is introduced to the Azure section to specify the gallery used to create Gen2 images. [1]: coreos/coreos-assembler#4109 [2]: coreos/fedora-coreos-config#3519
dustymabe
approved these changes
May 29, 2025
dustymabe
reviewed
May 29, 2025
| @@ -94,6 +94,7 @@ clouds: | |||
| test_resource_group: fedora-coreos-testing | |||
| test_storage_account: fedoracoreostesting | |||
| test_storage_container: fedora-coreos-testing-image-blobs | |||
| test_gallery: fedora-coreos-testing-gallery | |||
| test_architectures: [x86_64] | |||
There was a problem hiding this comment.
As a followup to this I'd really like to start testing aarch64 so we'd change this line (or possibly remove the functionality if it's no longer needed).
There was a problem hiding this comment.
I built an aarch64 image and ran a vm with it yesterday using coreos/coreos-assembler@fd81647. I'll open a PR to cosa after coreos/coreos-assembler#4109 merges.
marmijo
added a commit
to marmijo/fedora-coreos-pipeline
that referenced
this pull request
May 30, 2025
Zzure doesn't allow dashes (-) in gallery names so the gallery name is updated to not include them. Also, set the gallery name on image creation which should have been done in a previous commit. See: coreos#1153
marmijo
added a commit
to marmijo/fedora-coreos-pipeline
that referenced
this pull request
May 30, 2025
Azure doesn't allow dashes (-) in gallery names so the gallery name is updated to not include them. Also, set the gallery name on image creation which should have been done in a previous commit. See: coreos#1153
dustymabe
pushed a commit
that referenced
this pull request
May 30, 2025
Azure doesn't allow dashes (-) in gallery names so the gallery name is updated to not include them. Also, set the gallery name on image creation which should have been done in a previous commit. See: #1153
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the job to build Hyper-V Gen2 gallery images and run kola tests exclusively on those new images[1]. The new Azure NVMe test[2] requires NVMe support, which is only available with Gen2 gallery images. Since there are no constraints requiring Gen1 images, we simplify things by testing only Gen2.
A pipeline config variable,
test_gallery, is introduced to the Azure section to specify the gallery used to create Gen2 images.[1]: coreos/coreos-assembler#4109[2]: coreos/fedora-coreos-config#3519EDIT:
2025-05-29: reworked job to only build and test gen2 images.Note: this requires coreos/coreos-assembler#4109 to merge first.