This repository was archived by the owner on Aug 16, 2023. It is now read-only.
go module for dockerfile/parser #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
commented
Jan 17, 2022
| "github.com/docker/dockerfile/parser" | ||
| "github.com/docker/dockerfile/parser/command" | ||
| "github.com/moby/buildkit/util/suggest" |
There was a problem hiding this comment.
We should remove dependencies on buildkit itself. Looks like github.com/moby/buildkit/util/suggest is only used by the parser so suggest to move it here from BuildKit repo.
There was a problem hiding this comment.
There is also github.com/moby/buildkit/util/stack in parser/errors.go.
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
parser-gomod
branch
6 times, most recently
from
02b4e1b to
3c57af2
Compare
crazy-max
force-pushed
the
parser-gomod
branch
6 times, most recently
from
1427f7f to
4235fd3
Compare
crazy-max
commented
Jan 17, 2022
| annotations: false | ||
|
|
||
| fixes: | ||
| - "vendor/github.com/docker/dockerfile::" # move path to its original location |
There was a problem hiding this comment.
necessary with go submodule otherwise codecov loses track of the module path and looks in vendor dir instead:
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
parser-gomod
branch
from
4235fd3 to
73f1346
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move everything related to the parser to a dedicated pkg with its own go module to expose the minimum things needed.
this would require creating tags for the parser when we create a new release
parser/vx.x.x.