-
Notifications
You must be signed in to change notification settings - Fork 254
stop: fix the warn message in case of nil error #4773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
looks like it is missed during 0342835 one and when crc is stopped, it show following warn message. ``` WARN Failed to remove crc contexts from kubeconfig: <nil> Stopped the instance ``` This PR will make sure to handle nil error properly.
Reviewer's GuideAdjust Stop() cleanup logic to suppress logging when the cleanKubeconfig error is nil, preventing spurious warnings. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @praveenkumar - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
/retest |
@praveenkumar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
looks like it is missed during 0342835 one and when crc is stopped, it show following warn message.
This PR will make sure to handle nil error properly.
Contribution Checklist
Summary by Sourcery
Bug Fixes:
<nil>
error