LLVM LexicalScopes build exception when building with --release flag

[fridgerator]

I was able to build fine in OSX, however Ubuntu 16.04 is failing with this error:

remote: crystal: /var/cache/omnibus/src/llvm/llvm-3.8.1.src/lib/CodeGen/LexicalScopes.cpp:160: llvm::LexicalScope* llvm::LexicalScopes::getOrCreateRegularScope(const llvm::DILocalScope*): Assertion cast(Scope)->describes(MF->getFunction())' failed.`

Originally reported by @crisward here

Replicated by @hak8or and @matiasgarciaisaia. @matiasgarciaisaia mentioned that building with --no-debug works as a temporary workaround.

[crisward]

Has anyone tried build with --release on llvm 3.8.1 on mac? Mac ships with llvm 4.0, so this could be an llvm version issue.

[straight-shoota]

quote from @matiasgarciaisaia

It's really weird to see that /var/cache/omnibus/... there, given that the Crystal package doesn't install that.

It's really weird. That /var/cache/omnibus directory doesn't even exist on my machine and should never be created.

[konovod]

I have similar (but maybe not identical) problem:

crystal: /var/cache/omnibus/src/llvm/llvm-3.8.1.src/include/llvm/IR/DataLayout.h:513: uint64_t llvm::DataLayout::getTypeSizeInBits(llvm::Type*) const: Assertion `Ty->isSized() && "Cannot getTypeInfo() on a type that is unsized!"' failed.
/usr/bin/crystal: line 102:  6027 Aborted                 (core dumped) "$INSTALL_DIR/embedded/bin/crystal" "$@"

https://travis-ci.org/konovod/linalg/builds/253769479
Maybe offtopic (and i still haven't found minimal example for reporting), but it also has /var/cache/omnibus and also appeared after 0.23.1 so i think worth mentioning.

[crisward]

I also don't have /var/cache/omnibus/ and get that error. Also this is very easy to reproduce.

# on Ubuntu 14.04
sudo apt-get install crystal
echo 'p "hello world"' > test.cr
crystal build test.cr --release

crystal: /var/cache/omnibus/src/llvm/llvm-3.8.1.src/lib/CodeGen/LexicalScopes.cpp:160: llvm::LexicalScope* llvm::LexicalScopes::getOrCreateRegularScope(const llvm::DILocalScope*): Assertion `cast<DISubprogram>(Scope)->describes(MF->getFunction())' failed.
/usr/bin/crystal: line 102: 16249 Aborted                 "$INSTALL_DIR/embedded/bin/crystal" "$@"

[RX14]

I don't find it confusing at all. It's telling you the location in the source file where the runtime assertion failed, doesn't mean the source file has to be there on the PC where it runs, because it's a compiled library. It's exactly the same as __FILE__ in crystal.

[straight-shoota]

@konovod This runs without --release, so it seems to be a different thing, still might as well be related. Perhaps it's an issue with liblapacke?
Does this error also appear on local builds? And is it present in 0.23.0 or the inofficial release of 0.23.1 (#4647)?

[straight-shoota]

@RX14 Ok, makes sense. I didn't expect LLVM to have such detailed internal debug info in a released binary^^

@crisward Even smaller example would be crystal eval --release 'p "hello world'

[RX14]

It appears to me that LLVM was manually compiled by the omnibus, instead of using a prebuilt version. By the appearance of assertion errors, it's probably not a release build either. It's likely a release build would simply not have these runtime checks.

[konovod]

Does this error also appear on local builds?

Still haven't managed to get it on local build. If assertions in llvm are present, perhaps this problem is unrelated.

[crisward]

Also

• crystal eval --release 'p "hello world"' --no-debug works
• crystal eval --release 'p "hello world"' fails

[crisward]

Not sure if this is relevant but the old llvm setup used to configure disable-assertions

crystal-lang/omnibus-crystal@57e0ebc#diff-004ad5a5c6f368464daff6c7cbde83a5L26

[crisward]

Looks like setting CMAKE_BUILD_TYPE to debug makes it enable assertions otherwise it's in disabled. So probably not that then.

[RX14]

@crisward confusingly, I think that's the wrong branch: https://github.com/crystal-lang/omnibus-crystal/blob/current/config/software/llvm.rb

Still has assertions disabled, even though it's not a release build.

[crisward]

That version doesn't appear to have CMAKE_BUILD_TYPE set at all, though the docs don't indicate the default setting. Perhaps setting it to MinSizeRel would do the trick?