Implement Exception::CallStack#frames
#10686
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
force-pushed
the
feature/exception-callstack-frames
branch
from
915864f to
22945d2
Compare
Sija
force-pushed
the
feature/exception-callstack-frames
branch
from
22945d2 to
92ee0ee
Compare
|
No force pushes please 🙏 |
asterite
reviewed
May 7, 2021
| line : Int32?, | ||
| column : Int32?, | ||
| name : String?, | ||
| sname : String?, |
There was a problem hiding this comment.
It comes from LibC::DlInfo#dli_sname (Name of symbol whose definition overlaps addr).
There was a problem hiding this comment.
It helps with clean API and I don't see a reason to not to expose it and deny it to consumers.
Sija
force-pushed
the
feature/exception-callstack-frames
branch
from
e7a6883 to
3ea2fe0
Compare
Moar structured form of `Exception::CallStack#printable_backtrace`.
That’s meant to test the CI fails
Sija
force-pushed
the
feature/exception-callstack-frames
branch
2 times, most recently
from
7f95236 to
f9ed098
Compare
Sija
force-pushed
the
feature/exception-callstack-frames
branch
from
f9ed098 to
bfc2b48
Compare
asterite
reviewed
May 9, 2021
| column : Int32?, | ||
| name : String?, | ||
| sname : String?, | ||
| ip_address : UInt64 do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Exception::CallStack::Framerecord as a more structured form ofException::CallStack#printable_backtrace.Resolves #10681