-
-
Notifications
You must be signed in to change notification settings - Fork 75
Wire logical into Preset Env and CLI #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Antonio-Laguna
merged 24 commits into
feature/logical-revamp-v8
from
feature/wire-logical-into-preset-env
Jan 23, 2023
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
c2c877f
remove extra space
Antonio-Laguna 1c52e2b
remove plugin-options for logical
Antonio-Laguna b8ecc03
include new logical plugins
Antonio-Laguna 5e3f220
minor format
Antonio-Laguna 1487ad0
removing redundant if within shared-options
Antonio-Laguna 643e870
adding shared logical options to preset-env options
Antonio-Laguna 743e4fa
ensuring logical options get passed
Antonio-Laguna e27e685
updating tests
Antonio-Laguna bd7499d
adding tests for logical options
Antonio-Laguna 30c4d00
removing wrong object
Antonio-Laguna 3335c5c
adding test for logical
Antonio-Laguna 0f7f01a
adding clear and resize to the CHANGELOG
Antonio-Laguna beafa9a
updating tests and built files
Antonio-Laguna dc88c92
Updating CSSDB
Antonio-Laguna 294a4bb
Generating FEATURES
Antonio-Laguna f16412c
update CHANGELOG and README
Antonio-Laguna 42aaf49
Updating tests for ratios
Antonio-Laguna 63dd47d
Adding missing example
Antonio-Laguna 958fa52
Merge branch 'postcss-preset-env--v8' into feature/wire-logical-into-…
Antonio-Laguna d2d04d2
Updating CLI
Antonio-Laguna a20d67a
Merge branch 'feature/logical-revamp-v8' into feature/wire-logical-in…
romainmenke cc3d298
Merge remote-tracking branch 'origin/feature/logical-revamp-v8' into …
romainmenke 7379730
rebuild
romainmenke 317e0d4
a few tweaks and some more tests
romainmenke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
cli/csstools-cli/src/plugins/postcss-logical-float-and-clear.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import plugin from '@csstools/postcss-logical-float-and-clear'; | ||
import { cli, helpTextLogger } from '@csstools/base-cli'; | ||
|
||
export default function postcssLogical() { | ||
cli( | ||
plugin, | ||
['inlineDirection', 'blockDirection'], | ||
helpTextLogger( | ||
'@csstools/cli postcss-logical-float-and-clear', | ||
'PostCSS Logical Float And Clear', | ||
'Lets you use flow-relative (inline-start and inline-end) values for float and clear, following the CSS Logical Properties and Values specification.', | ||
{ | ||
inlineDirection: 'left-to-right', | ||
}, | ||
), | ||
false, | ||
); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import plugin from '@csstools/postcss-logical-resize'; | ||
import { cli, helpTextLogger } from '@csstools/base-cli'; | ||
|
||
export default function postcssLogicalResize() { | ||
cli( | ||
plugin, | ||
['inlineDirection'], | ||
helpTextLogger( | ||
'@csstools/cli postcss-logical-resize', | ||
'PostCSS Logical Resize', | ||
'Lets you use logical values in the resize property, following the CSS Logical Properties and Values specification.', | ||
{ | ||
inlineDirection: 'left-to-right', | ||
}, | ||
), | ||
false, | ||
); | ||
} |
19 changes: 19 additions & 0 deletions
19
cli/csstools-cli/src/plugins/postcss-logical-viewport-units.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import plugin from '@csstools/postcss-logical-viewport-units'; | ||
import { cli, helpTextLogger } from '@csstools/base-cli'; | ||
|
||
export default function postcssLogicalViewportUnits() { | ||
cli( | ||
plugin, | ||
['inlineDirection', 'preserve'], | ||
helpTextLogger( | ||
'@csstools/cli postcss-viewport-units', | ||
'PostCSS Logical Viewport Units', | ||
'Lets you use vb and vi length units in CSS, following the CSS Values and Units Module Level 4 specification.', | ||
{ | ||
inlineDirection: 'left-to-right', | ||
preserve: true, | ||
}, | ||
), | ||
false, | ||
); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 0 additions & 7 deletions
7
plugin-packs/postcss-preset-env/dist/types/postcss-logical/plugin-options.d.ts
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest is missing from CSSDB I think I jumpstarted on this too soon.
Once we start to release and we make V8 go into
main
it should be safer to add the restUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can do a minor version in CSSDB where we add the plugins as polyfills?
I don't mind having some broken links on CSSDB for a while.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought, let's leave this as is for now.
FEATURES.md
can be updated without requiring a release.Doing
v8
first and then adding the links makes more sense :)