Skip to content

fix(tesseracrt): Fix filter params casting for BigQuery dialect #9720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2025

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Jun 27, 2025

This fixes queries with filters for BigQuery, when casting is needed (like cast to FLOAT64 for numbers).

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet

Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.20%. Comparing base (c16175b) to head (e1415e7).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9720   +/-   ##
=======================================
  Coverage   84.20%   84.20%           
=======================================
  Files         230      230           
  Lines       85320    85320           
=======================================
  Hits        71847    71847           
  Misses      13473    13473           
Flag Coverage Δ
cubesql 84.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon force-pushed the fix/params-cast-tesseract branch from d9c3dcf to e1415e7 Compare June 27, 2025 16:13
@KSDaemon KSDaemon marked this pull request as ready for review June 27, 2025 16:33
@KSDaemon KSDaemon requested review from a team as code owners June 27, 2025 16:33
@KSDaemon KSDaemon merged commit 7b48c27 into master Jun 27, 2025
82 checks passed
@KSDaemon KSDaemon deleted the fix/params-cast-tesseract branch June 27, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants