registered_triggers is not defined in new app

[Nxt3]

Using the below code for a new app and no matter what I try I can't get it to not throw an error on registered_triggers

registered_triggers = []

# start the app
@time_trigger('startup')
def personTrackerStartup():
    loadApp('location', makePersonTracker)


def makePersonTracker(config):
    global registered_triggers
    personID = config['person']
    personName = personID.split('.')[1]

    @task_unique(f'{personName}_tracker')
    @state_trigger(f'{personID} != {personID}.old')
    def tracker(value=None):
        return

        
    # register to global scope
    registered_triggers.append(tracker) # registered_triggers.append(tracker): NameError: global name 'registered_triggers' is not defined


def loadApp(app_name, factory):
    if 'apps' not in pyscript.config:
        return
    
    if app_name not in pyscript.config['apps']:
        return

    for app in pyscript.config['apps'][app_name]:
        factory(app)

I followed the Wiki for the structure but there's a good chance I'm doing something wrong.

[craigbarratt]

That code works correctly me for. What version of pyscript are you running?

[Nxt3]

v0.32

[craigbarratt]

I tried it with 0.32 and it still works for me. Specifically, I created this file config/pyscript/apps/test_person.py (I hardcoded the config):

registered_triggers = []

# start the app
@time_trigger('startup')
def personTrackerStartup():
    loadApp('location', makePersonTracker)


def makePersonTracker(config):
    global registered_triggers
    personID = config['person']
    personName = personID.split('.')[1]

    @task_unique(f'{personName}_tracker')
    @state_trigger(f'{personID} != {personID}.old')
    def tracker(value=None):
        print(f"got value={value}")
        return


    # register to global scope
    registered_triggers.append(tracker)


def loadApp(app_name, factory):
    factory({"person": "id1234.craig"})

and added this to config/configuration.yaml:

pyscript:
  apps:
    test_person:

After restarting, when I set id1234.craig = "hello3" I do see the got value=hello3 message in the log.

I'm not sure why it doesn't work in your setup.

[Nxt3]

My config YAML looks like this:

pyscript:
  allow_all_imports: false
  apps:
    person_tracker:
      - person: person.paul_rudd

That's correct, right?

[dlashua]

@Nxt3 Not quite correct.

In this piece of your code:

# start the app
@time_trigger('startup')
def personTrackerStartup():
    loadApp('location', makePersonTracker)

You are indicating that this app is named "location". So this file should be saved as pyscript/apps/location/__init__.py and your YAML should use the location key like:

pyscript:
  allow_all_imports: false
  apps:
    location:
      - person: person.paul_rudd

However, not having this bit correct would not result in the NameError you are seeing.

[Nxt3]

What goes inside the __init__.py

Edit: I re-read what you said and I absorbed it that time. 😅

[Nxt3]

However, not having this bit correct would not result in the NameError you are seeing.

Yep, I still see the same error despite fixing this. :\

[craigbarratt]

With debug on:

logger:
  logs:
    custom_components.pyscript: debug

can you send all the debug messages from pyscript?

[Nxt3]

Sure thing:

2020-10-28 10:53:15 DEBUG (SyncWorker_1) [custom_components.pyscript] load_scripts: skipping /config/pyscript/apps/speaker_group_volume.py because config not present
2020-10-28 10:53:15 DEBUG (MainThread) [custom_components.pyscript.global_ctx] reading and parsing /config/pyscript/apps/person_tracker.py
2020-10-28 10:53:15 DEBUG (MainThread) [custom_components.pyscript.global_ctx] reading and parsing /config/pyscript/modules/load_app.py
2020-10-28 10:53:15 DEBUG (MainThread) [custom_components.pyscript.global_ctx] reading and parsing /config/pyscript/bedroom_group_media.py
2020-10-28 10:53:15 DEBUG (MainThread) [custom_components.pyscript.global_ctx] reading and parsing /config/pyscript/bedroom_media.py
2020-10-28 10:53:15 DEBUG (MainThread) [custom_components.pyscript.global_ctx] reading and parsing /config/pyscript/modules/media_consts.py
2020-10-28 10:53:16 DEBUG (MainThread) [custom_components.pyscript.global_ctx] reading and parsing /config/pyscript/downstairs_group_media.py
2020-10-28 10:53:16 DEBUG (MainThread) [custom_components.pyscript.global_ctx] reading and parsing /config/pyscript/home_theater.py
2020-10-28 10:53:16 DEBUG (MainThread) [custom_components.pyscript.eval] file.home_theater: calling info("NameError: previousSource wasn't set", {})
2020-10-28 10:53:16 INFO (MainThread) [custom_components.pyscript.file.home_theater] NameError: previousSource wasn't set
2020-10-28 10:53:16 DEBUG (MainThread) [custom_components.pyscript.global_ctx] reading and parsing /config/pyscript/meta.py
2020-10-28 10:53:16 DEBUG (MainThread) [custom_components.pyscript.global_ctx] reading and parsing /config/pyscript/scheduled_triggers.py
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript] adding state changed listener and starting triggers
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger apps.person_tracker.personTrackerStartup is active
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.bedroom_media.resetBedroomSpeakerVolume is active
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.bedroom_media.adjustBedroomSpeakerVolume is active
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.downstairs_group_media.resetDownstairsGroupOverrides is active
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.downstairs_group_media.monitorDownstairsVolume is active
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.downstairs_group_media.restoreDownstairsGroupNightVoiceVolume is active
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.downstairs_group_media.restoreDownstairsGroupNightMusicVolume is active
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.downstairs_group_media.restoreDownstairsGroupVoiceVolume is active
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.downstairs_group_media.restoreDownstairsGroupMusicVolume is active
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.downstairs_group_media.setDownstairsGroupNightVoiceVolume is active
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.home_theater.fixVidyaAudio is active
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.meta.setLightThemeMorning is active
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.meta.setDarkThemeOnStartup is active
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.meta.setDarkThemeEvening is active
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.meta.setLightThemeOnStartup is active
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.scheduled_triggers.nightlyTurnOffLights is active
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger apps.person_tracker.personTrackerStartup got None trigger, running action (kwargs = {'trigger_type': 'time', 'trigger_time': None})
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger apps.person_tracker.personTrackerStartup finished
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.bedroom_media.resetBedroomSpeakerVolume time_next = 2020-10-29 07:52:18, now = 2020-10-28 10:53:21.399985
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.bedroom_media.resetBedroomSpeakerVolume waiting for 75536.600015 secs
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.bedroom_media.adjustBedroomSpeakerVolume: watching vars {'media_player.bedroom_speaker.old', 'media_player.bedroom_speaker'}
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.bedroom_media.adjustBedroomSpeakerVolume waiting for state change or event
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.downstairs_group_media.resetDownstairsGroupOverrides time_next = 2020-10-29 07:52:18, now = 2020-10-28 10:53:21.408774
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.downstairs_group_media.resetDownstairsGroupOverrides waiting for 75536.591226 secs
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.downstairs_group_media.monitorDownstairsVolume: watching vars {'media_player.living_room_speaker.volume_level', 'media_player.kitchen_speaker.volume_level'}
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.downstairs_group_media.monitorDownstairsVolume waiting for state change or event
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.downstairs_group_media.restoreDownstairsGroupNightVoiceVolume: watching vars {'media_player.downstairs_group.old', 'media_player.downstairs_group'}
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.downstairs_group_media.restoreDownstairsGroupNightVoiceVolume waiting for state change or event
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.downstairs_group_media.restoreDownstairsGroupNightMusicVolume: watching vars {'media_player.downstairs_group.old', 'media_player.downstairs_group'}
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.downstairs_group_media.restoreDownstairsGroupNightMusicVolume waiting for state change or event
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.downstairs_group_media.restoreDownstairsGroupVoiceVolume: watching vars {'media_player.downstairs_group.old', 'media_player.downstairs_group'}
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.downstairs_group_media.restoreDownstairsGroupVoiceVolume waiting for state change or event
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.downstairs_group_media.restoreDownstairsGroupMusicVolume: watching vars {'media_player.downstairs_group.old', 'media_player.downstairs_group'}
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.downstairs_group_media.restoreDownstairsGroupMusicVolume waiting for state change or event
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.downstairs_group_media.setDownstairsGroupNightVoiceVolume time_next = 2020-10-28 22:30:00, now = 2020-10-28 10:53:21.428292
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.downstairs_group_media.setDownstairsGroupNightVoiceVolume waiting for 41798.571708 secs
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.home_theater.fixVidyaAudio: watching vars {'previousSource', 'media_player.tv_vizio.source'}
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.home_theater.fixVidyaAudio waiting for state change or event
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.meta.setLightThemeMorning time_next = 2020-10-29 07:52:18, now = 2020-10-28 10:53:21.429101
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.meta.setLightThemeMorning waiting for 75536.570899 secs
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.meta.setDarkThemeOnStartup time_next = 2020-10-29 00:00:00, now = 2020-10-28 10:53:21.429971
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.meta.setDarkThemeOnStartup waiting for 47198.570029 secs
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.meta.setDarkThemeEvening time_next = 2020-10-28 18:49:47, now = 2020-10-28 10:53:21.430442
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.meta.setDarkThemeEvening waiting for 28585.569558 secs
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.meta.setLightThemeOnStartup time_next = 2020-10-29 00:00:00, now = 2020-10-28 10:53:21.433782
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.meta.setLightThemeOnStartup waiting for 47198.566218 secs
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.scheduled_triggers.nightlyTurnOffLights time_next = 2020-10-29 03:00:00, now = 2020-10-28 10:53:21.434668
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger file.scheduled_triggers.nightlyTurnOffLights waiting for 57998.565332 secs
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.eval] apps.person_tracker.personTrackerStartup: calling loadApp("person_tracker", <custom_components.pyscript.eval.EvalFuncVar object at 0x7fa7cad280>, {})
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.eval] apps.person_tracker.personTrackerStartup: calling factory({'person': 'person.paul_rudd'}, {})
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.eval] apps.person_tracker.personTrackerStartup: calling get("person", {})
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.eval] apps.person_tracker.personTrackerStartup: calling split(".", {})
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger apps.person_tracker.tracker is active
2020-10-28 10:53:21 ERROR (MainThread) [custom_components.pyscript.apps.person_tracker.personTrackerStartup] Exception in <apps.person_tracker.personTrackerStartup> line 66:
registered_triggers.append(tracker)
^
NameError: global name 'registered_triggers' is not defined
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger apps.person_tracker.tracker: watching vars {'person.paul_rudd.old', 'person.paul_rudd'}
2020-10-28 10:53:21 DEBUG (MainThread) [custom_components.pyscript.trigger] trigger apps.person_tracker.tracker waiting for state change or event
2020-10-28 10:53:22 ERROR (Recorder) [homeassistant] Error doing job: Unclosed connection
2020-10-28 10:58:13 DEBUG (MainThread) [custom_components.pyscript.state] state.update({'person.paul_rudd': 'home', 'person.paul_rudd.old': 'home'}, {'trigger_type': 'state', 'var_name': 'person.paul_rudd', 'value': 'home', 'old_value': 'home'})
2020-10-28 11:00:04 DEBUG (MainThread) [custom_components.pyscript.state] state.update({'person.paul_rudd': 'home', 'person.paul_rudd.old': 'home'}, {'trigger_type': 'state', 'var_name': 'person.paul_rudd', 'value': 'home', 'old_value': 'home'})
2020-10-28 11:03:03 DEBUG (MainThread) [custom_components.pyscript.state] state.update({'person.paul_rudd': 'home', 'person.paul_rudd.old': 'home'}, {'trigger_type': 'state', 'var_name': 'person.paul_rudd', 'value': 'home', 'old_value': 'home'})

[dlashua]

Can you also provide a gist/pastebin of apps/person_tracker/__init__.py. From this debug output, it appears to have changed since your last share.

[Nxt3]

Yeah sorry I changed the name of the file and app to person_tracker so everything is consistent.

How do I find that file? I'm not seeing apps/person_tracker/__init__.py.

[craigbarratt]

This file: /config/pyscript/apps/person_tracker.py

Could you also post /config/pyscript/home_theater.py, since there is a NameError there earlier in the log.

Hopefully there is some way for me to replicate this issue. Failing that, I might propose some extra debugging code for you to run.

[Nxt3]

Here's a gist of the files in question

[dlashua]

I get the same error as you with these exact files. However, if I move loadApp into person_tracker.py I do not get this error.

I believe the reason for this is that registered_triggers is defined inside of person_tracker.py. However, the factory method (makePersonTracker in this case) is being called from load_app.py where registered_triggers is not defined. Adding registered_triggers = [] to the top of load_app.py fixed it for me.

[Nxt3]

What do ya know. That fixed the issue. :) thank you so much for the help